Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignition #1301

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Remove ignition #1301

merged 5 commits into from
Aug 4, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 27, 2023

🎉 New feature

Remove ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig marked this pull request as draft July 27, 2023 12:54
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1301 (23a9ac7) into main (91876e7) will not change coverage.
The diff coverage is n/a.

❗ Current head 23a9ac7 differs from pull request most recent head 673e816. Consider uploading reports for the commit 673e816 to get more accurate results

@@           Coverage Diff           @@
##             main    #1301   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files         128      128           
  Lines       16830    16830           
=======================================
  Hits        14744    14744           
  Misses       2086     2086           

Signed-off-by: Nate Koenig <[email protected]>
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig marked this pull request as ready for review August 2, 2023 12:17
@nkoenig nkoenig changed the base branch from main to sdf13 August 2, 2023 12:23
@nkoenig nkoenig changed the base branch from sdf13 to main August 2, 2023 12:23
@azeey azeey merged commit af88891 into main Aug 4, 2023
10 checks passed
@azeey azeey deleted the nkoenig/remove-ign branch August 4, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants