-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy 1.10 spec to 1.11 for sdformat14 #1298
Conversation
Signed-off-by: Jasmeet Singh <[email protected]>
Signed-off-by: Jasmeet Singh <[email protected]>
Signed-off-by: Jasmeet Singh <[email protected]>
one failed expectation in Root_TEST.cc that should be easy to fix: |
Signed-off-by: Jasmeet Singh <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures are caused by some updates to the spec that have not been included in this PR. Can you merge from main
and copy some of the new changes in sdf/1.10
to sdf/1.11
?
Signed-off-by: Jasmeet Singh <[email protected]>
Signed-off-by: Jasmeet Singh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1298 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 128 128
Lines 16830 16830
=======================================
Hits 14744 14744
Misses 2086 2086 |
Signed-off-by: Addisu Z. Taddese <[email protected]>
I found additional differences when I did |
🎉 New feature
This PR creates a new version of the SDF spec 1.11 targeted for the
sdformat14
. It would be required by the Automatic Moment of Inertia Calculation project. The SDF proposal for the same can be found hereChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.