Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted Custom Rendering Sensor Example #2406

Open
wants to merge 3 commits into
base: gz-sim8
Choose a base branch
from

Conversation

JEller98
Copy link

@JEller98 JEller98 commented May 14, 2024

🦟 Bug fix

Fixes #1673

Summary

This is an attempt at implementing a custom rendering example as discussed in Issue #1673. There is an attempt to create a CameraSensor in the PostUpdate method, then pass the pointer to the bitmap field found within a given Image and pass said pointer to FreeImage's FlipHorizontal method.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Disclaimer

This solution is experimental at best, as I'm very inexperienced; this is actually my first time writing C++ and my first time attempting to contribute to FOSS. I felt very out of my depth while attempting to implement this solution. Constructive criticism, if anyone is willing to provide it, is more than welcome.

No tests have been written due to my inexperience regarding the testing frameworks used, and no offense will be taken if this request is not accepted.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

…; code is completely untested and no tests have been written for it.
…; code is completely untested and no tests have been written for it.
@JEller98 JEller98 requested a review from mjcarroll as a code owner May 14, 2024 10:23
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 14, 2024
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey
Copy link
Contributor

azeey commented Aug 12, 2024

Thank you for submitting this PR. Since this will require more iteration before it's ready, I'll remove the beta label, which means we'll hold of from reviewing and merging it until Ionic is released (end of September, 2024). You might still get reviews in the meantime, but it's unlikely.

@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

Custom rendering sensor example
2 participants