Change auth method in releasepy: remove shared token and use Jenkins API tokens #1201
+118
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
nuclearsandwich
approved these changes
Nov 8, 2024
Signed-off-by: Jose Luis Rivero <[email protected]>
|
The second commit in the PR changes the auth model from using a job token via GET parameter named 'token' to use a basic_auth model over https using POST. It works with the same config file than the |
j-rivero
changed the title
scpeters
reviewed
Nov 14, 2024
| import subprocess | ||
| import sys | ||
| import tempfile | ||
| import os | ||
| import urllib.parse | ||
| import urllib.request | ||
| import urllib3 |
There was a problem hiding this comment.
it would be helpful to document somewhere the python dependencies needed to run release.py. I am using a python venv, so with trial and error I installed the missing dependencies, but it could be clearer
There was a problem hiding this comment.
Or avoid using libraries outside of the python standard libraries if possible.
|
Note that this needs to wait to be merged to #1206 to be ready |
Provide a cli option to inject credentials designed to work with nightly. This has the side effect on the test code that we no longer need the _RELEASEPY_TEST_CREDENTIAL. Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making @nuclearsandwich happy. Remove the token used in DSL.
Developers documentation update: gazebosim/docs#538
This change will break existing nightly scheduler calls. A subsequent PR should take care of it.