Validate and improve german translation #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amr21code
approved these changes
Mar 22, 2022
|
I think I saw you closed a previous pull request, is this a new version? Thank you both by the way! I wish I had access to approve yours. I'm trying to get in contact with @gawindx so I can take care of some PRs. |
|
My version was actually newer but kind of a duplicate. Didnt check before my request so I just closed it. |
|
Greetings everyone, I've started a pull request to merge German translation fixes into the new repository. Please review and provide feedback here: nutdotnet/WinNUT-Client#8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this nice tool over the last weeks for the first time, I noticed some misleading or wrong german translations as well as some improvements for better understanding.
I updated the CSV as mentioned in
README.mdand used the following principle:To validatetoValidand keep original translatorValid.To Validate. Review comments on those lines about where to find the corresponding strings would be appreciated, so I could amend this PR accordingly if needed.