Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Gatsby-Plugin-Offline Double Reload Issue #39042

Closed
wants to merge 29 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
33beb90
Fix #25207: Ensure assetPrefix and pathPrefix are correctly applied t…
emmron Jul 12, 2024
b884195
Fix code formatting issues with prettier
emmron Jul 12, 2024
a2637c3
Fix #25207: Ensure assetPrefix and pathPrefix are correctly applied t…
emmron Jul 12, 2024
48587e8
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 12, 2024
6ccff34
Fix #25207: Apply assetPrefix and pathPrefix to URLs in manifest.webm…
emmron Jul 12, 2024
574e403
Fix #25207: Apply assetPrefix and pathPrefix to URLs in manifest.webm…
emmron Jul 12, 2024
1308d71
Fix #25207: Apply assetPrefix and pathPrefix to URLs in manifest.webm…
emmron Jul 12, 2024
873a67d
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
3599f19
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
8c31c6e
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
c1a510e
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
e7b756b
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
d742649
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
eb2ac79
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
1758b85
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
d3e46e8
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
66f06e6
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 12, 2024
53dda5d
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 12, 2024
b4be36a
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 12, 2024
3fd95e6
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 12, 2024
c2357b1
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
111ff8f
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
emmron Jul 12, 2024
5e7d907
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 12, 2024
df40f79
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 12, 2024
fb4acb7
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 12, 2024
b6e8af2
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 13, 2024
0b07e26
i am a retard
emmron Jul 13, 2024
5bbd458
Fix #25207: Ensure assetPrefix, pathPrefix, and basePath are correctl…
emmron Jul 13, 2024
5aaa0bf
Fix: Ensure gatsby-plugin-offline provides offline experience on the …
emmron Jul 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,10 @@ commands:
default: ""
steps:
- checkout
# In case of failure, add these steps again. Cache probably got deleted
#- <<: *restore_cache
#- <<: *install_node_modules
#- <<: *persist_cache
- unless:
condition: << parameters.skip_file_change_test >>
steps:
- run: ./scripts/assert-changed-files.sh "<< parameters.trigger_pattern >>|<< parameters.test_path >>/*"

- when:
condition: << parameters.slices >>
steps:
Expand Down
1 change: 1 addition & 0 deletions .cursorignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Add directories or file patterns to ignore during indexing (e.g. foo/ or *.csv)
30 changes: 0 additions & 30 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,16 +120,10 @@ module.exports = {
plugins: [`@typescript-eslint/eslint-plugin`],
extends: [`plugin:@typescript-eslint/recommended`],
rules: {
// We should absolutely avoid using ts-ignore, but it's not always possible.
// particular when a dependencies types are incorrect.
"@typescript-eslint/ban-ts-comment": [
`warn`,
{ "ts-ignore": `allow-with-description` },
],
// This rule is great. It helps us not throw on types for areas that are
// easily inferrable. However we have a desire to have all function inputs
// and outputs declaratively typed. So this let's us ignore the parameters
// inferrable lint.
"@typescript-eslint/no-inferrable-types": [
`error`,
{ ignoreParameters: true },
Expand All @@ -149,7 +143,6 @@ module.exports = {
},
],
camelcase: `off`,
// TODO: These rules allow a lot of stuff and don't really enforce. If we want to apply our styleguide, we'd need to fix a lot of stuff
"@typescript-eslint/naming-convention": [
`error`,
{
Expand Down Expand Up @@ -207,20 +200,8 @@ module.exports = {
prefix: [`I`],
},
],
// This rule tries to prevent using `require()`. However in node code,
// there are times where this makes sense. And it specifically is causing
// problems in our tests where we often want this functionality for module
// mocking. At this point it's easier to have it off and just encourage
// using top-level imports via code reviews.
"@typescript-eslint/no-var-requires": `off`,
"@typescript-eslint/no-extra-semi": `off`,
// This rule ensures that typescript types do not have semicolons
// at the end of their lines, since our prettier setup is to have no semicolons
// e.g.,
// interface Foo {
// - baz: string;
// + baz: string
// }
"@typescript-eslint/member-delimiter-style": [
`error`,
{
Expand All @@ -230,13 +211,7 @@ module.exports = {
},
],
"@typescript-eslint/no-empty-function": `off`,
// This ensures that we always type the return type of functions
// a high level focus of our TS setup is typing fn inputs and outputs.
"@typescript-eslint/explicit-function-return-type": `error`,
// This forces us to use interfaces over types aliases for object definitions.
// Type is still useful for opaque types
// e.g.,
// type UUID = string
"@typescript-eslint/consistent-type-definitions": [
`error`,
`interface`,
Expand All @@ -245,9 +220,6 @@ module.exports = {
`error`,
{ functions: false },
],
// Allows us to write unions like `type Foo = "baz" | "bar"`
// otherwise eslint will want to switch the strings to backticks,
// which then crashes the ts compiler
quotes: `off`,
"@typescript-eslint/quotes": [
2,
Expand All @@ -256,8 +228,6 @@ module.exports = {
avoidEscape: true,
},
],
// bump to @typescript-eslint/parser started showing Flow related errors in ts(x) files
// so disabling them in .ts(x) files
"flowtype/no-types-missing-file-annotation": `off`,
"@typescript-eslint/array-type": [`error`, { default: `generic` }],
},
Expand Down
Loading