Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump lmdb to 2.3.10 #35585

Merged
merged 6 commits into from
May 6, 2022
Merged

chore: bump lmdb to 2.3.10 #35585

merged 6 commits into from
May 6, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented May 4, 2022

Description

Bumps lmdb. It required updating our webpack loader that patches lmdb for bundling engines. lmdb moved to different way of distributing binaries - for now it uses forked node-gyp-build (node-gyp-build-optional-packages) for now - there is PR against node-gyp-build prebuild/node-gyp-build#45 and once that's merged we probably can expect lmdb going back to regular node-gyp-build (PR is written in a way that should handle this switch back in the future without the need of adjusting our patch)

Related Issues

[ch50149]
Possibly unblocks #35576
Get more debugging information with newer LMDB version ( kriszyp/lmdb-js#153 )

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 4, 2022
@pieh pieh added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 4, 2022
@pieh
Copy link
Contributor Author

pieh commented May 5, 2022

This is blocked on kriszyp/lmdb-js#166 (comment) for now

@pieh pieh changed the title chore: bump lmdb to 2.3.8 chore: bump lmdb to 2.3.10 May 6, 2022
@pieh pieh marked this pull request as ready for review May 6, 2022 07:29
@wardpeet wardpeet merged commit c410214 into master May 6, 2022
@wardpeet wardpeet deleted the bump-lmdb branch May 6, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants