Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps lmdb. It required updating our webpack loader that patches lmdb for bundling engines.
lmdb
moved to different way of distributing binaries - for now it uses forkednode-gyp-build
(node-gyp-build-optional-packages
) for now - there is PR againstnode-gyp-build
prebuild/node-gyp-build#45 and once that's merged we probably can expectlmdb
going back to regularnode-gyp-build
(PR is written in a way that should handle this switch back in the future without the need of adjusting our patch)Related Issues
[ch50149]
Possibly unblocks #35576
Get more debugging information with newer LMDB version ( kriszyp/lmdb-js#153 )