Rank hands without tiebreaker #2

garthgoldwater · 2014-07-14T22:07:36Z

gabebw · 2014-07-14T22:13:40Z

hand_ranker.rb

+
+  def <=>(other_hand)
+    if rank > other_hand.rank || rank < other_hand.rank
+      rank <=> other_hand.rank


Why not just do this always? It will Do The Right Thing in all cases. I think the if is unnecessary.

my big problem is if rank is equal and i need to do tiebreaking in the future

garthgoldwater · 2014-07-14T22:14:49Z

there's maybe one line of code i like here

gabebw · 2014-07-14T22:15:23Z

hand_classifier.rb

+class HandClassifier
+  def initialize(hand)
+    @hand = hand
+    @rank = classify


This is doing a lot of work in an initializer. How about not having @rank at all and forcing other classes to call .classify?

Rank hands without tiebreaker

54846ff

gabebw reviewed Jul 14, 2014
View reviewed changes

Garth Goldwater added 2 commits July 14, 2014 18:19

do first round of gabe suggestions

fd0eca1

use fancy hash syntax

9246183

Provide feedback