Skip to content

Commit

Permalink
Fix Javadocs in ColumnCapablities.java (apache#17462)
Browse files Browse the repository at this point in the history
  • Loading branch information
GWphua authored Nov 12, 2024
1 parent 3f56b57 commit 8278a1f
Showing 1 changed file with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,34 +38,34 @@ public interface ColumnCapabilities extends TypeSignature<ValueType>
/**
* Is the column dictionary encoded? If so, a DimensionDictionarySelector may be used instead of using a value
* selector, allowing algorithms to operate on primitive integer dictionary ids rather than the looked up dictionary
* values
* values.
*/
Capable isDictionaryEncoded();

/**
* If the column is dictionary encoded, are those values sorted? Useful to know for optimizations that can defer
* looking up values and allowing sorting with the dictionary ids directly
* looking up values and allowing sorting with the dictionary ids directly.
*/

Capable areDictionaryValuesSorted();

/**
* If the column is dictionary encoded, is there a 1:1 mapping of dictionary ids to values? If this is true, it
* unlocks optimizations such as allowing for things like grouping directly on dictionary ids and deferred value
* lookup
* lookup.
*/
Capable areDictionaryValuesUnique();

/**
* String columns are sneaky, and might have multiple values, this is to allow callers to know and appropriately
* prepare themselves
* prepare themselves.
*/
Capable hasMultipleValues();

/**
* Does the column have an inverted index bitmap for each value? If so, these may be employed to 'pre-filter' the
* column by examining if the values match the filter and intersecting the bitmaps, to avoid having to scan and
* evaluate if every row matches the filter
* evaluate if every row matches the filter.
*/
boolean hasBitmapIndexes();

Expand All @@ -76,7 +76,7 @@ public interface ColumnCapabilities extends TypeSignature<ValueType>

/**
* Does this column contain null values? If so, callers, especially for primitive numeric columns, will need to check
* for null value rows and act accordingly
* for null value rows and act accordingly.
*/
Capable hasNulls();

Expand Down Expand Up @@ -164,7 +164,7 @@ public String toString()
}

/**
* This interface defines the shape of a mechnism to allow for bespoke coercion of {@link Capable#UNKNOWN} into
* This interface defines the shape of a mechanism to allow for bespoke coercion of {@link Capable#UNKNOWN} into
* {@link Capable#TRUE} or {@link Capable#FALSE} for each {@link Capable} of a {@link ColumnCapabilities}, as is
* appropriate for the situation of the caller.
*/
Expand All @@ -177,13 +177,13 @@ interface CoercionLogic
boolean dictionaryEncoded();

/**
* If {@link ColumnCapabilities#areDictionaryValuesSorted()} ()} is {@link Capable#UNKNOWN}, define if it should be
* If {@link ColumnCapabilities#areDictionaryValuesSorted()} is {@link Capable#UNKNOWN}, define if it should be
* treated as true or false.
*/
boolean dictionaryValuesSorted();

/**
* If {@link ColumnCapabilities#areDictionaryValuesUnique()} ()} is {@link Capable#UNKNOWN}, define if it should be
* If {@link ColumnCapabilities#areDictionaryValuesUnique()} is {@link Capable#UNKNOWN}, define if it should be
* treated as true or false.
*/
boolean dictionaryValuesUnique();
Expand All @@ -196,7 +196,7 @@ interface CoercionLogic

/**
* If {@link ColumnCapabilities#hasNulls()} is {@link Capable#UNKNOWN}, define if it should be treated as true
* or false
* or false.
*/
boolean hasNulls();
}
Expand Down

0 comments on commit 8278a1f

Please sign in to comment.