Fix test.sh by using the supplied command in docker-entrypoint.sh

[MaddieM4]

Docker uses a 2-part separation between the ENTRYPOINT command (which is what's always run in docker run) and the CMD command (which is provided as arguments to the ENTRYPOINT script). Right now, test.sh doesn't work because it's attempting to override CMD, but docker-entrypoint.sh is ignoring CMD in favor of a hardcoded call to /usr/sbin/vsftpd.

The fix for this is really easy, as you can see by the patch size! Specify what we were already doing as the CMD and have docker-entrypoint.sh call it. This means when you override CMD like test.sh does, docker-entrypoint.sh respects what you ask for.

[garethflowers]

The image was setup exactly like this previously (see #63). However, because of the way vsftpd was handling child process it meant that the container would keep exiting whenever a ftp connection was closed.

Changing to use ENTRYPOINT seemed to fix that issue.

[MaddieM4]

That's so weird! There were little clues it used to work this way (well, test.sh really), but I didn't have context why it was changed. I haven't seen the exit behavior in my environment, which is Docker on Mac for Apple Silicon. I may have to do a bit of research. It's also worth exploring whether this was tied to a vsftpd version that has now automatically been superceded by Dependabot, which would be nice in terms of simple fixes (if true), but make it harder to confirm the original pathology. My best guess is that the problem is the "exec", and you might find a working approach that uses CMD but calls it as a subprocess in the entrypoint script, not as an in-place process replacement. That's my best explanation for why the patch you linked fixed the issue - it seemed really suspicious that hard coding the CMD would help, but calling vsftpd as a subprocess is a subtle difference that could actually affect child reaping semantics, and I think that's the part of the fix that really made the server work.

…

On Sun, Jan 28, 2024, 9:39 AM Gareth Flowers ***@***.***> wrote: The image was setup exactly like this previously (see #63 <#63>). However, because of the way vsftpd was handling child process it meant that the container would keep exiting whenever a ftp connection was closed. Changing to use ENTRYPOINT seemed to fix that issue. — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACGVVENREUX2P5VCKRMTM3YQ2EMZAVCNFSM6AAAAABCEIQS66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGY3TANZXGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>