Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add same git clone options that we used to have in gitlab-ci. #66

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

alee-ntap
Copy link
Contributor

@alee-ntap alee-ntap commented Dec 13, 2023

What this PR does / why we need it:
For building aws-sdk-cpp, we need --recurse-submodules options.
Checked our gitlab-ci and found we should add these options into the git clone:

--jobs $(nproc) --shallow-submodules --recurse-submodules

Details:
https://gitlab.com/gardenlinux/gardenlinux-package-build/-/blob/main/pipeline/source-git.yml?ref_type=heads#L58

Which issue(s) this PR fixes:
Fixes #67

@nanory nanory self-requested a review December 13, 2023 11:10
Copy link
Contributor

@nanory nanory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanory nanory merged commit 3c6e67b into main Dec 13, 2023
5 checks passed
@nanory nanory deleted the fix/git-clone-options branch December 13, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcing mechanism does not take submodules into account
2 participants