Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg.yml and adjust versioning logic #23

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Conversation

nanory
Copy link
Contributor

@nanory nanory commented Nov 23, 2023

What this PR does / why we need it:
This PR gets rid of the pkg.yml and ensures that the Git Tag of a project determines the version of the package. Otherwise, the Git commit hash is taken

Which issue(s) this PR fixes:
Fixes #5

@gardener-robot
Copy link
Contributor

@nanory Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 23, 2023
@nanory nanory force-pushed the feature/5-remove-pkg-yml branch from 8af7b90 to 6eed6f7 Compare November 23, 2023 19:10
@nanory nanory force-pushed the feature/5-remove-pkg-yml branch 16 times, most recently from ac3604f to 8530b1e Compare November 24, 2023 17:30
@nanory nanory force-pushed the feature/5-remove-pkg-yml branch from 8530b1e to ae3cb1e Compare November 24, 2023 17:42
@alee-ntap
Copy link
Contributor

Tested this workflow changes works with apt_source, git_source and also native three different type of packages:
https://github.com/gardenlinux/package-htop/actions/runs/6983646731
https://github.com/gardenlinux/package-iproute2/actions/runs/7003594089
https://github.com/gardenlinux/package-iproute2/actions/runs/7004046530

I think we may now drop the hardcoded ref: feature/5-remove-pkg-yml and merge.

@alee-ntap
Copy link
Contributor

I'm now dropping the hardcoded ref: feature/5-remove-pkg-yml line. Ready for merge,.

@alee-ntap alee-ntap force-pushed the feature/5-remove-pkg-yml branch from 19e0add to 0e7a037 Compare November 27, 2023 14:26
@alee-ntap alee-ntap force-pushed the feature/5-remove-pkg-yml branch 21 times, most recently from 9a64e5c to a1378d8 Compare November 27, 2023 16:22
@alee-ntap alee-ntap force-pushed the feature/5-remove-pkg-yml branch from a1378d8 to 1a4725b Compare November 27, 2023 16:31
@alee-ntap
Copy link
Contributor

I started to migrate package-systemd, and I found we can optimize the build.yml by use:

jobs:
  build_pkg:
    uses: gardenlinux/package-build/.github/workflows/build_pkg.yml@main

So that we don’t need --arg name "$name" '.jobs[$name]. in the yq command in build_source script.
So that all thebuild.yml files from other package-* will be only has difference on the first line with name, eg:

name: systemd

I will adjust the workflow in this PR.

@nanory nanory merged commit aaf6b65 into main Nov 28, 2023
4 checks passed
@nanory nanory deleted the feature/5-remove-pkg-yml branch November 28, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace pkg.yml with workflow variables
3 participants