Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2 add support for native package builds #21

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

alee-ntap
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #2

Special notes for your reviewer:
In Gardenlinux, there are two types of native packages: those directly sourced from Debian, such as base-files, and those specific to Gardenlinux, such as gardenlinux-selinux-module.

To accommodate these two types of native packages, two commits are proposed:

  • Enhancing the apt_source() function:
    The first commit aims to enhance the existing apt_source() function to support native packages sourced directly from Debian. This enhancement will enable the function to handle the retrieval and installation of native packages from the Debian repository.

  • Adding the native_source() function:
    The second commit involves adding the native_source() function to the codebase. This function will be triggered when the pkg.yaml file specifies source: native for a native package. The native_source() function will handle the necessary actions for handling Gardenlinux-specific native packages. Due to the build_source script already handles the source package name, so that we do not need to specific source package name but native is simply enough for our own native package support.

By introducing these commits, the build_source mechanism will be improved. It will no longer require explicitly specifying the source package name for native packages. Instead, using the keyword native will be sufficient to identify and support Gardenlinux's own native packages.

Release note:

@gardener-robot
Copy link
Contributor

@alee-ntap Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 22, 2023
Copy link
Contributor

@nanory nanory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanory nanory merged commit bacc01c into main Nov 23, 2023
5 checks passed
@nanory nanory deleted the feature/2-add-support-for-native-package-builds branch November 23, 2023 16:26
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for native package builds to the build container
4 participants