Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/13 move build scripts and bind mount #16

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

alee-ntap
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #13

Special notes for your reviewer:

There is another -test branch for test this PR that specified branch for action/checkout that contains all these changes. Tested workflow with changes in this PR utilized by package-htop:
https://github.com/gardenlinux/package-htop/actions/runs/6941494228

Release note:
NONE

@gardener-robot
Copy link
Contributor

@alee-ntap Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 21, 2023
@alee-ntap
Copy link
Contributor Author

After discussion, it has been decided to retain the inclusion of the build_* scripts within the container images to support local builds. Therefore, I will proceed with updating the current PR to reflect this decision.

To ensure that the workflow can be properly tested in the development branch, we still require the use of a bind mount when bringing up the container. However, this bind mount should only be applied within the workflow.

Considering that the build_* scripts are already available under /usr/local/bin within the container images, we need to bind mount this directory to /usr/local/sbin. This will enable the possibility of workflow development tests while the necessary scripts available inside the container in the workflow.

By making these adjustments, we can support both local builds by keeping the build_* scripts inside the container images, and also support workflow development and testing in the development branch.

@alee-ntap alee-ntap force-pushed the feature/13-move-build_scripts-and-bind-mount branch from 1edaf37 to 0a1e2da Compare November 21, 2023 16:17
@alee-ntap alee-ntap force-pushed the feature/13-move-build_scripts-and-bind-mount branch from 0a1e2da to f63f75f Compare November 21, 2023 16:18
Copy link
Contributor

@nanory nanory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanory nanory merged commit 061a580 into main Nov 21, 2023
5 checks passed
@nanory nanory deleted the feature/13-move-build_scripts-and-bind-mount branch November 21, 2023 16:58
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move build_* scripts into scripts/ and bind mount in container
3 participants