Use 1.21.0 instead of 1.21 as module version
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
kind/bug
gardener-prow
bot
added
the
size/XS
|
It seems that /hold |
gardener-prow
bot
added
the
do-not-merge/hold
from v3.4.1 to v3.4.5 [email protected] contains a fix for incu6us/goimports-reviser#129.
ialidzhikov
force-pushed
the
fix/go.mod
branch
from
ac1afd5 to
d7cb55e
Compare
|
/unhold [email protected] contains a fix for the issue described in #39 (comment). d7cb55e does a temporary patch to update the goimports-reviser to v3.4.5. |
gardener-prow
bot
removed
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 78bd811a02a71c4547d35803ebb5067396718f5a
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind bug
What this PR does / why we need it:
Currently dependabot fails with:
See dependabot/dependabot-core#7895 and golang/go#62278.
It seems that with go1.21 it is no longer possible to have
X.Yas module version - see golang/go#62278 (comment).Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note: