Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup handling for disabled UseGardenerNodeAgent feature gate #920

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Cleanup handling for disabled UseGardenerNodeAgent feature gate #920

merged 1 commit into from
Apr 11, 2024

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area open-source
/kind cleanup
/platform aws

What this PR does / why we need it:
This PR cleans up the handling for disabled UseGardenerNodeAgent feature gate.

Which issue(s) this PR fixes:
Part of gardener/gardener#8023

Special notes for your reviewer:
Follow-up of #913 and #854

Release note:

This extension is no longer able to run with Gardener versions lower than `v1.90` when the `UseGardenerNodeAgent` feature gate is disabled.

@rfranzke rfranzke requested review from a team as code owners April 10, 2024 10:39
@gardener-robot gardener-robot added the needs/review Needs review label Apr 10, 2024
@rfranzke rfranzke mentioned this pull request Apr 10, 2024
Closed
55 tasks
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up platform/aws Amazon web services platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Apr 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 10, 2024
AndreasBurger
AndreasBurger approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@AndreasBurger AndreasBurger merged commit 49dadd5 into gardener:master Apr 11, 2024
15 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 11, 2024
@rfranzke rfranzke deleted the cleanup branch April 12, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/aws Amazon web services platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfranzke @AndreasBurger @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot