Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Docker from provisioning OSC #205

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove Docker from provisioning OSC #205

wants to merge 1 commit into from

Conversation

MrBatschner
Copy link
Contributor

How to categorize this PR?

/area os
/kind technical-debt
/os suse-chost

What this PR does / why we need it:

As Kubernetes in general and Gardener in particular no longer support docker as container runtime (and no longer require it for unpacking OCI images), it is no longer necessary to install docker with zypper during node bootstrap.

Which issue(s) this PR fixes:
Fixes #194

Special notes for your reviewer:

Release note:

The suse-chost OS extension no longer installs docker with zypper during bootstrap of a cHost node.

@MrBatschner
remove docker from OSC provision
0867151 
As Kubernetes in general and Gardener in particular no longer support
docker as container runtime (and no longer reqire it for unpacking
OCI images), it is no longer necessary to install docker with zypper
during node bootstrap.
@gardener-robot gardener-robot added area/os Operation system related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly os/suse-chost Related to SUSE Container Host OS needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 22, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 22, 2025
@MrBatschner
Copy link
Contributor Author

MrBatschner commented Jan 23, 2025 •
edited
Loading

Hi @ialidzhikov : Do you think your comment in PR gardener/gardener-extension-os-gardenlinux#221 is also valid here? Forget about this question, you even wrote that into the issue already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/os Operation system related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review os/suse-chost Related to SUSE Container Host OS size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing the installation and enablement of the docker unit
4 participants
@MrBatschner @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot