This repository has been archived by the owner on May 26, 2024. It is now read-only.
Remove nerdctl workaround for local OS image
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Closed
55 tasks
rfranzke
changed the title
nerdctl workaround for local OS image
ScheererJ
approved these changes
Mar 26, 2024
|
@ScheererJ Command |
gardener-robot
added
reviewed/lgtm
|
Love it, very nice! 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Now that
gardener-node-agentis the only default, we no longer neednerdctlto fake thedockerCLI for shoot worker nodes.Which issue(s) this PR fixes:
Part of gardener/gardener#8023
Part of gardener/gardener#4673
Special notes for your reviewer:
/cc @oliver-goetz @ScheererJ @timebertt