-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP(7): Component folder structure #2886
Conversation
@scotthallock is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
This PR is really big. It's always good to create smaller PRs because they're easier to review, unless it's necessary like if you're doing a migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub CI/CD failed. Could you look into it? I think it's complaining that there are changed snapshots.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2886 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 190 190
Lines 3576 3576
Branches 970 970
=========================================
Hits 3576 3576
|
Should be fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the only issue is that it's big. I hope you'd make the next PRs smaller :)
Will do! |
Related to #2080
This PR folders creates folders for:
LessonCard
LessonLayout
LessonTitleCard
MarkdownToolbar
MdInput
ModalCard
NavLink
NextPreviousLessons
ProfileDropdownMenu