Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(7): Component folder structure #2886

Merged
merged 10 commits into from
Apr 5, 2023

Conversation

scotthallock
Copy link
Collaborator

Related to #2080

This PR folders creates folders for:

  • LessonCard
  • LessonLayout
  • LessonTitleCard
  • MarkdownToolbar
  • MdInput
  • ModalCard
  • NavLink
  • NextPreviousLessons
  • ProfileDropdownMenu

@vercel
Copy link

vercel bot commented Apr 5, 2023

@scotthallock is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@scotthallock scotthallock changed the title Dev#2080 WIP(7): Component folder structure Apr 5, 2023
@flacial
Copy link
Member

flacial commented Apr 5, 2023

This PR is really big. It's always good to create smaller PRs because they're easier to review, unless it's necessary like if you're doing a migration.

Copy link
Member

@flacial flacial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub CI/CD failed. Could you look into it? I think it's complaining that there are changed snapshots.

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 0:06am

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2886 (30d49bc) into master (775c859) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 30d49bc differs from pull request most recent head bb2591c. Consider uploading reports for the commit bb2591c to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2886   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines         3576      3576           
  Branches       970       970           
=========================================
  Hits          3576      3576           
Impacted Files Coverage Δ
components/ChallengeMaterial/ChallengeMaterial.tsx 100.00% <ø> (ø)
components/CommentBox/CommentBox.tsx 100.00% <ø> (ø)
...mponents/ExerciseReportCard/ExerciseReportCard.tsx 100.00% <ø> (ø)
components/FormCard/FormCard.tsx 100.00% <ø> (ø)
components/LessonCard/LessonCard.tsx 100.00% <ø> (ø)
components/LessonLayout/LessonLayout.tsx 100.00% <ø> (ø)
components/LessonTitleCard/LessonTitleCard.tsx 100.00% <ø> (ø)
components/MarkdownToolbar/MarkdownToolbar.tsx 100.00% <ø> (ø)
components/ModalCard/ModalCard.tsx 100.00% <ø> (ø)
...onents/NextPreviousLessons/NextPreviousLessons.tsx 100.00% <ø> (ø)
... and 5 more

@scotthallock
Copy link
Collaborator Author

Should be fixed now!

Copy link
Member

@flacial flacial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only issue is that it's big. I hope you'd make the next PRs smaller :)

@scotthallock
Copy link
Collaborator Author

Looks good, the only issue is that it's big. I hope you'd make the next PRs smaller :)

Will do!

@scotthallock scotthallock added this pull request to the merge queue Apr 5, 2023
Merged via the queue into garageScript:master with commit 60d8d48 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦄 Done
Development

Successfully merging this pull request may close these issues.

2 participants