New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect #3

Merged

Bashorun97 merged 19 commits into main from feat/eb-connect

Jun 17, 2024

Contributor

Bashorun97 commented Jun 6, 2024 •

edited

Loading

URL and QRCode generation

Video

https://www.loom.com/share/195bc65705524a158f6efd8044e55f35?sid=075344bb-4c65-42de-a287-270342ea4501

Images

Bashorun97 added 2 commits

June 5, 2024 13:07


          Connect golib

b84799c

Signed-off-by: Bashorun97 <[email protected]>


          Connect example

d7bb170

Signed-off-by: Bashorun97 <[email protected]>

Bashorun97 requested review from TheDhejavu and timigod

June 6, 2024 01:10

TheDhejavu reviewed

View reviewed changes

connect/connect.go Outdated Show resolved Hide resolved

TheDhejavu reviewed

View reviewed changes

connect/types.go Show resolved Hide resolved

TheDhejavu reviewed

View reviewed changes

connect/filename.json Outdated Show resolved Hide resolved

TheDhejavu reviewed

View reviewed changes

connect/big_encode.json Outdated Show resolved Hide resolved

TheDhejavu reviewed

View reviewed changes

connect/example/main.go Outdated Show resolved Hide resolved

Contributor

TheDhejavu commented Jun 6, 2024

when trait goes to prod, i believe this implementation will eventually have to change but this is also necessary due to backward compatibility.

TosinJs commented Jun 6, 2024 •

edited

Loading

when trait goes to prod, i believe this implementation will eventually have to change but this is also necessary due to backward compatibility.

cc @TosinJs

Yes, the backward compatible implementation with Traits and Android support can be found here: gandalf-network/connect#18

timigod requested changes

View reviewed changes

Contributor

timigod left a comment

I don’t see your QR code generation working.

2.Seems like you only implemented the soon to be deprecated (but not breaking) Connect flow where the dev passes “services”, but if you remember the trait spec we have a new one where the dev passes “data”. You can ask Tosin for where that code is in the JS SDK.


          Resolve review comments

fea918c

Signed-off-by: Bashorun97 <[email protected]>

Bashorun97 force-pushed the feat/eb-connect branch 2 times, most recently from c040074 to a981e01 Compare

June 7, 2024 11:54


          Update example code

5a8ff9f

Signed-off-by: Bashorun97 <[email protected]>

Bashorun97 force-pushed the feat/eb-connect branch from a981e01 to 5a8ff9f Compare

June 7, 2024 11:55

Bashorun97 requested review from timigod and TheDhejavu

June 7, 2024 11:56

TheDhejavu reviewed

View reviewed changes

.gitpod.yml Outdated Show resolved Hide resolved

TheDhejavu reviewed

View reviewed changes

connect/connect_test.go Outdated Show resolved Hide resolved

Contributor

TheDhejavu commented Jun 10, 2024

@Bashorun97 Scroll to the bottom of the readme and update it to include connect.


          Update connect.go

ea99894

Bashorun97 requested a review from TosinJs

June 10, 2024 10:57

TosinJs reviewed

View reviewed changes

connect/connect.go

+              )
+              var (
+              	IOS_APP_CLIP_BASE_URL = "https://appclip.apple.com/id?p=network.gandalf.connect.Clip"

TosinJs Jun 10, 2024

Could we put this in an ENV like the others.

Bashorun97 added 5 commits

June 11, 2024 08:45


          Connect tests and docs

0f224dc

Signed-off-by: Bashorun97 <[email protected]>


          Merge pull request #4 from gandalf-network/feat/eb-docs-test

7ee8196

Connect tests and docs


          Update readme

af0cb78

Signed-off-by: Bashorun97 <[email protected]>


          Merge branch 'main' into feat/eb-docs-test

8cd8db1


          Traits docs

0970f72

Signed-off-by: Bashorun97 <[email protected]>

Bashorun97 added 9 commits

June 15, 2024 13:54


          Android docs

071facd

Signed-off-by: Bashorun97 <[email protected]>


          Resolve merge conflicts

9ce69e9

Signed-off-by: Bashorun97 <[email protected]>


          Update docs

0f30cb6

Signed-off-by: Bashorun97 <[email protected]>


          Update docs

57e3c5c

Signed-off-by: Bashorun97 <[email protected]>


          Update generated.go import path

ea98a7d

Signed-off-by: Bashorun97 <[email protected]>


          Clean up redundant generated files

a3b669f

Signed-off-by: Bashorun97 <[email protected]>


          Clean up redundant generated files

2e2a0f7

Signed-off-by: Bashorun97 <[email protected]>


          Update docs

640f62f

Signed-off-by: Bashorun97 <[email protected]>


          Merge pull request #6 from gandalf-network/feat/eb-docs-test

a412edc

Feat/eb docs test

Bashorun97 merged commit 0e86045 into main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet