Skip to content

Commit

Permalink
v3.2.2 released - bug fixed and added a waning when using advancedRef…
Browse files Browse the repository at this point in the history
…reshView on Android
  • Loading branch information
gameboyVito committed Sep 18, 2017
1 parent 275ea7c commit b0638ec
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"native-base": "^2.3.1",
"react": "16.0.0-alpha.12",
"react-native": "0.46.1",
"react-native-ultimate-listview": "^3.2.0"
"react-native-ultimate-listview": "^3.2.2"
},
"devDependencies": {
"babel-jest": "20.0.3",
Expand Down
6 changes: 3 additions & 3 deletions Example/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3153,9 +3153,9 @@ [email protected]:
prop-types "^15.5.10"
react-timer-mixin "^0.13.3"

react-native-ultimate-listview@^3.2.0:
version "3.2.0"
resolved "https://registry.yarnpkg.com/react-native-ultimate-listview/-/react-native-ultimate-listview-3.2.0.tgz#6c613af97da5fac03fc5350088431033f1eb3d38"
react-native-ultimate-listview@^3.2.2:
version "3.2.2"
resolved "https://registry.yarnpkg.com/react-native-ultimate-listview/-/react-native-ultimate-listview-3.2.2.tgz#682f13db53bcd4c6856b112d6a526a71e1b0fae6"

react-native-vector-icons@~4.1.1:
version "4.1.1"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This is an **enhanced FlatList** with all excellent extra features, comparing to
**Quick installation**

- If on react-native < 0.43: `yarn add [email protected]`
- If on react-native >= 0.43 `yarn add react-native-ultimate-listview@3.2.0`
- If on react-native >= 0.43 `yarn add react-native-ultimate-listview@latest`



Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-ultimate-listview",
"version": "3.2.1",
"version": "3.2.2",
"description": "A high performance FlatList providing customised pull-to-refresh | auto-pagination & infinite-scrolling | gridview layout | swipeable-row. The truly ultimate version that I have done the most tricky part for you, just simply follow the instructions shown below to put it in your app.",
"main": "index.js",
"scripts": {
Expand Down
5 changes: 4 additions & 1 deletion src/refreshableScrollView.android.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export default class RefreshableScrollView extends ScrollView {
}

componentDidMount() {
console.warn('The advancedRefreshView is not ready for Android at this moment. \n\nIf the items are less than the height of device screen, the refreshView will not disappear. \n\nPlease consider setting the refreshableMode={Platform.OS === "ios" ? "advanced" : "basic"}, or feel free to send me a PR to resolve this problem. \n\nThanks a lot.');
AsyncStorage.getItem(DATE_KEY, (error, result) => {
if (result) {
result = parseInt(result);
Expand Down Expand Up @@ -160,7 +161,9 @@ export default class RefreshableScrollView extends ScrollView {
showRefreshHeader: true,
});
setTimeout(() => {
this.refs.scrollView.scrollTo({x: 0, y: this.props.refreshViewHeight, animated: true});
if (this.refs.scrollView.scrollTo) {
this.refs.scrollView.scrollTo({x: 0, y: this.props.refreshViewHeight, animated: true});
}
this.setState({
refreshStatus: RefreshStatus.pullToRefresh,
refreshTitle: this.props.refreshableTitlePull,
Expand Down

0 comments on commit b0638ec

Please sign in to comment.