Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #48

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Conversation

HavenOfTheRaven
Copy link
Contributor

I updated dependencies to their latest versions while testing to ensure that nothing broke. I was unable to update three packages due to compilation errors, those being:
openxr 0.17.1 -> 0.18.0
ash 0.37.3 -> 0.38.0
vulkano 94f50f1 -> b9f3e89

@galister
Copy link
Owner

Please keep ash as is, we need the same version that vulkano pulls in.

@HavenOfTheRaven
Copy link
Contributor Author

Please keep ash as is, we need the same version that vulkano pulls in.

Vulkano at 94f50f1 uses ash 0.37.3, if you would like I can revert ash to 0.37.2 in Cargo.toml?

@galister
Copy link
Owner

oh nvm then, thanks

@HavenOfTheRaven
Copy link
Contributor Author

Would you like me to fix the compilation errors on vulkano and ash so we can update them?

@HavenOfTheRaven
Copy link
Contributor Author

I decided to take a look at the errors and was easily able to fix them for the new ash and vulkano versions. I then did some testing to confirm everything still worked fine. Currently the only dependency at an earlier version is openxr.

@HavenOfTheRaven
Copy link
Contributor Author

openxr cannot be updated to 0.18.0 since it removes the extx_overlay ExtensionSet, this was added back in with a later commit. Just to clarify ash being updated to 0.38.0 does not create a conflict with Vulkano since Vulkano at b9f3e89 uses ash 0.38.0 as well.

@galister galister merged commit c06ec6d into galister:main Jun 16, 2024
5 checks passed
@galister
Copy link
Owner

thanks!

@HavenOfTheRaven
Copy link
Contributor Author

THANK YOU this is one of my first pull requests

@HavenOfTheRaven HavenOfTheRaven deleted the Update-Dependencies branch June 17, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants