LPS-174018 Get the proper parameter #347
Conversation
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
…ayoutTabScreenNavigationEntry
…try for each ObjectLayoutTab
MarinhoFeliphe
force-pushed
the
LPS-174018
branch
from
1eb1962 to
8bb683f
Compare
MarinhoFeliphe
force-pushed
the
LPS-174018
branch
from
9949af3 to
9a5f60a
Compare
| } | ||
|
|
||
| @Override | ||
| public String getScreenNavigationKey() { |
There was a problem hiding this comment.
@MarinhoFeliphe This value must be unique. We should follow some pattern like {className}#{LayoutERC} or {className}#{companyId}#{LayoutERC}.
P.S.: We should check if the tracker of this is scoped by company or not. I don't think so.
There was a problem hiding this comment.
@MarinhoFeliphe can you open a thread with he FI Team so we can ask about scoping issues (regarding company).
There was a problem hiding this comment.
we don't have ERC for ObjectLayout yet, may I use layoutId?
can you open a thread with he FI Team ...
sure!
|
|
||
| @Override | ||
| public String getEntryKey() { | ||
| return String.valueOf(_objectLayoutTab.getObjectLayoutTabId()); |
There was a problem hiding this comment.
@MarinhoFeliphe here we can put the same pattern I suggested above
| @@ -389,6 +405,25 @@ private ObjectLayoutTab _addObjectLayoutTab( | |||
| user, objectDefinitionId, | |||
| objectLayoutTab.getObjectLayoutTabId(), objectLayoutBoxes)); | |||
|
|
|||
| _serviceRegistrationsMap.put( | |||
There was a problem hiding this comment.
@MarinhoFeliphe hm... Instead of registering two components, we can follow the pattern we have for object definition admin screens.
We can have a Base class for the ScreenEntry and extend It, implementing also the ScreenNavigationCategory. That way, we register just one class. And then you can override the getScreenNavigationKey and put the ObjectDefinition className + companyId + ERC like {className#companyId#ERC}
…igationCategories
…ject definition in object layout
…ryKey and screenNavigationKey
…is point because won't affect the order of the tabs once it won't apply the reverse order in ScreenNavigationRegistry.activate method
…object layout tab
… and deleteObjectLayoutObjectLayoutTabs methods
No description provided.