Skip to content

Commit

Permalink
Merge pull request #124 from ga4gh-discovery/develop
Browse files Browse the repository at this point in the history
Release 1.0
  • Loading branch information
mcupak authored Jun 22, 2021
2 parents 3deed25 + 3a9be1f commit 70f5bbf
Show file tree
Hide file tree
Showing 36 changed files with 4,166 additions and 318 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,6 @@ Session.vim

#********** IntelliJ files ******
*.iml

# built docs
built_docs/
5 changes: 5 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[submodule "clyde"]
path = hugo/themes/clyde
url = https://github.com/DNAstack/clyde.git
branch = v1.1.1

34 changes: 28 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,31 @@ dist: bionic
sudo: false
jdk:
- openjdk11
env:
- GH_URL=https://raw.githubusercontent.com FILE_TO_VALIDATE=spec/search-api.yaml URL_TO_VALIDATE=$GH_URL/${TRAVIS_PULL_REQUEST_SLUG:-$TRAVIS_REPO_SLUG}/${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}/$FILE_TO_VALIDATE
before_install:
- git clone --branch=v1.1.0 https://github.com/mcupak/oas-validator.git
script:
- ./oas-validator/validate.sh "$URL_TO_VALIDATE"

jobs:
include:
- name: validation
language: java
jdk: openjdk11
env:
- GH_URL=https://raw.githubusercontent.com FILE_TO_VALIDATE=spec/api.yaml URL_TO_VALIDATE=$GH_URL/${TRAVIS_PULL_REQUEST_SLUG:-$TRAVIS_REPO_SLUG}/${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}/$FILE_TO_VALIDATE
before_install:
- git clone --branch=v1.1.0 https://github.com/mcupak/oas-validator.git
script:
- ./oas-validator/validate.sh "$URL_TO_VALIDATE"
- name: docs
language: node_js
node_js: 14
before_install:
- npm install -g @redocly/openapi-cli && npm install -g redoc-cli
- wget "https://github.com/gohugoio/hugo/releases/download/v0.79.0/hugo_extended_0.79.0_Linux-64bit.deb" && sudo dpkg -i hugo*.deb
script:
- git submodule update --remote --merge
- make build_prod
deploy:
provider: pages
skip-cleanup: true
keep_history: false
github-token: $GITHUB_TOKEN
on:
branch: develop
21 changes: 20 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,30 @@ Some general rules to follow:
- Create a branch for each update that you're working on. These branches are often called "feature" or "topic" branches. Any changes that you push to your feature branch will automatically be shown in the pull request.
- Keep your pull requests as small as possible. Large pull requests are hard to review. Try to break up your changes into self-contained and incremental pull requests.
- The first line of commit messages should be a short (<80 character) summary, followed by an empty line and then any details that you want to share about the commit.
- Each pull request should be associated with an issue.
- Please try to follow [common commit message conventions](https://chris.beams.io/posts/git-commit/).

### Voting
Once a pull request or issue have been submitted, maintainers can comment or vote on to express their opinion following the [Apache voting system](https://www.apache.org/foundation/voting.html). Quick summary:

- +1 something you agree with
- -1 if you have a strong objection to an issue, which will be taken very seriously. A -1 vote should provide an alternative solution.
- +0 or -0 for neutral comments or weak opinions.
- It's okay to have input without voting.
- Silence gives assent.
- In a pull request review:
- Approval is considered a +1 vote on the pull request.
- "Request changes" is considered a -1 vote on the pull request.
- A pull request is ready to be merged when either of the following is true:
- A pull request has at least two +1 votes, no -1 votes, and has been open for at least 3 days.
- A pull request has no -1 votes, and has been open for at least 14 days.
- We sometimes waive the time constraint for cosmetic-only changes -- use good judgment. If an issue gets any -1 votes, the comments on the issue need to reach consensus before the issue can be resolved one way or the other. There isn't any strict time limit on a contentious issue.

The project will strive for full consensus on everything until it runs into a problem with this model.

### Topic branches

If you wish to collaborate on a new feature with other GA4GH members, you can create a topic branch. Once a topic branch exists, pull requests can be made against it the usual way. It may also be brought up to date with new changes merged into develop by anyone with commit access, if the changes produce merely a fast-forward merge for each constituent branch. However, if changes from the develop branch create a new merge commit in or or more of the repositories, that commit needs to be reviewed in a pull request.
If you wish to collaborate on a new feature with other GA4GH members, you can create a topic branch. Once a topic branch exists, pull requests can be made against it the usual way. It may also be brought up to date with new changes merged into `develop` by anyone with commit access, if the changes produce merely a fast-forward merge for each constituent branch. However, if changes from the `develop` branch create a new merge commit, that commit needs to be reviewed in a pull request.

Changes made in a topic branch can be merged into develop by creating a pull request against the `develop` branch and then resolving the normal way.

Expand Down
23 changes: 23 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
run: build_api_docs
echo "start run"
cd hugo && hugo serve -D
build: build_api_docs
echo "start doc build"
git submodule update --init --recursive
echo "start hugo build"
cd hugo && hugo --minify -d ../built_docs/
echo "end build"
build_prod: build_api_docs
echo "start prod doc build"
echo -e "\033[33mUSE MAKE BUILD FOR TESTING LOCALLY, DON'T TRACK docs/!\033[0m"
git submodule update --init --recursive
echo "start hugo build"
cd hugo && hugo --minify -d ../docs/
echo "end prod build"
build_api_docs:
echo "start api docs build"
redoc-cli bundle spec/api.yaml
mkdir -p `dirname ./hugo/content/api/index.html`
mv ./redoc-static.html ./hugo/content/api/index.html
clean:
rm -rf hugo/docs/ docs/ built_docs/ hugo/built_docs/ hugo/content/api/index.html
Loading

0 comments on commit 70f5bbf

Please sign in to comment.