fixed : Searching for a location in Autocomplete search bar and selecting it , makes the floating card shows loading indicator infinitely - IOS Specific #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed this issue fysoul17#68
|
This will cause some weird behavior when moving the pin. It will show the old address until the new one is load, so this is not really a fix. However, the key is to set it the SearchingState to Idle after completing the search through the AutoCompleteSearch, my PR #147 addresses this. Your changes are not required. You must not alter the check that you did, or the weird bug with the old address showing up will appear. |
|
@fysoul17 This should be closed, it's deprecated and not necessary anymore. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a problem in the IOS platform ... which is
related issue #68