internal/driver/mobile: tidy unused code #2437
Conversation
|
@andydotxyz @Jacalz Now rebased on top of the latest develop branch. The diff should be nice for the review. |
|
Hmm. Interesting, what causes the failure? It was all passed. |
gldebug is not really useful and never being used today. There are too many ways to debug gl stuff on different platforms. Logging is the poorest one.
I missed something in Windows test code that somehow got into develop - it's all working smoothly again, sorry |
|
Sorry for the delay, let's pick this up after v2.1 (just a few more days). |
|
I don't currently have any cross compiling setups for mobile devices, so I'll just ask out of curiously. Does this make the mobile binaries any smaller? If so, how much? 🙂 |
Yes, a little bit. We still have to rely on cgo anyway (Obj-C and Java). #911 was discussing Windows which will have significant improvements on the binary size. But still, this reduces the binary size a bit: iOS:
Android:
|
|
@changkun Thanks for the numbers. You have successfully cured my curiosity for now. Thanks for working on this :) |
|
@andydotxyz ping |
|
Yeah sorry - still catching up on backlog, this is on my list for tomorrow! |
Description:
This is the 3rd pull request of a series of pull requests intended to remove the fyne-io/mobile dependency, as per discussed in #2428.
This change does a few simplifications of the internal/driver/mobile package, containing remove unused packages, remove used functions, etc (only 42 GL functions are used for fyne, it might be a good motivation for fyne to write a custom clean gl package, instead of depending on a go-gl package where a gl.go file is in 2MB size).
Updates #843
@andydotxyz @Jacalz
Checklist: