Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Clone Settings complete reimbursable export settings #285

Merged
merged 59 commits into from
Sep 6, 2023
Merged

Clone Settings complete reimbursable export settings #285

merged 59 commits into from
Sep 6, 2023

Conversation

NileshPant1999
Copy link
Contributor

@NileshPant1999 NileshPant1999 commented Jul 29, 2023 •
edited
Loading

Screenshot 2023-07-31 at 7 25 05 PM Screenshot 2023-07-31 at 7 25 23 PM Screenshot 2023-07-31 at 7 25 28 PM Screenshot 2023-07-31 at 7 25 30 PM

@NileshPant1999 NileshPant1999 changed the base branch from master to clone-settings-qbo July 29, 2023 19:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #285 (34e7c03) into master (b147abe) will decrease coverage by 2.75%.
Report is 1 commits behind head on master.
The diff coverage is 53.10%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   96.52%   93.77%   -2.75%     
==========================================
  Files         122      131       +9     
  Lines        3019     3182     +163     
  Branches      484      508      +24     
==========================================
+ Hits         2914     2984      +70     
- Misses         53      125      +72     
- Partials       52       73      +21
Files Changed Coverage Δ
...p/core/models/configuration/clone-setting.model.ts 0.00% <0.00%> (ø)
.../core/models/configuration/export-setting.model.ts 27.27% <ø> (ø)
.../app/core/services/integration/tracking.service.ts 84.09% <0.00%> (-1.96%) ⬇️
...ion/employee-settings/employee-settings.fixture.ts 100.00% <ø> (ø)
...uration/export-settings/export-settings.fixture.ts 100.00% <ø> (ø)
...nfiguration/qbo-connector/qbo-connector.fixture.ts 100.00% <ø> (ø)
...nfirmation-dialog/confirmation-dialog.component.ts 80.00% <0.00%> (-20.00%) ⬇️
src/app/shared/shared.module.ts 100.00% <ø> (ø)
...e/services/configuration/export-setting.service.ts 39.47% <30.30%> (-60.53%) ⬇️
...iguration/qbo-connector/qbo-connector.component.ts 89.58% <33.33%> (-10.42%) ⬇️
... and 12 more

... and 4 files with indirect coverage changes

@NileshPant1999 NileshPant1999 changed the base branch from clone-settings-qbo to master July 31, 2023 12:23
@NileshPant1999
Copy link
Contributor Author

@ashwin1111 just letting you know that, i will fix all the content related issue together in one pr later once i got it from Kamalini

ashwin1111
ashwin1111 reviewed Aug 1, 2023
View reviewed changes
src/app/core/models/configuration/export-setting.model.ts Outdated
@@ -32,7 +36,7 @@ export type ExportSettingGet = {
}

export interface ExportSettingFormOption extends SelectFormOption {
value: ExpenseState | CCCExpenseState | ReimbursableExpensesObject | CorporateCreditCardExpensesObject | ExpenseGroupingFieldOption | ExportDateType;
value: ExpenseState | CCCExpenseState | ReimbursableExpensesObject | CorporateCreditCardExpensesObject | ExpenseGroupingFieldOption | ExportDateType | AutoMapEmployee | EmployeeFieldMapping | null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need AutoMapEmployee or EmployeeFieldMapping as a part of export setting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwin1111 this was an initial change, will remove it added it earlier forget to remove.

src/app/core/services/configuration/clone-setting.service.ts Outdated
return this.apiService.get(`/v2/workspaces/${this.workspaceId}/clone_settings/`, {});
}

saveCloneSettings(cloneSettingsPayload: CloneSettingPost): Observable<CloneSetting> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postClone...

...pp/shared/components/clone-settings/clone-import-settings/clone-import-settings.component.ts Outdated Show resolved Hide resolved
src/styles.scss Outdated Show resolved Hide resolved
src/app/integration/onboarding/clone-settings/clone-settings.component.ts Outdated Show resolved Hide resolved
src/app/integration/onboarding/clone-settings/clone-settings.component.ts Outdated Show resolved Hide resolved
src/app/integration/onboarding/clone-settings/clone-settings.component.ts Outdated Show resolved Hide resolved
src/app/integration/onboarding/clone-settings/clone-settings.component.ts Outdated Show resolved Hide resolved
src/app/integration/onboarding/clone-settings/clone-settings.component.ts Outdated Show resolved Hide resolved
@ashwin1111 ashwin1111 temporarily deployed to End to End Test - Staging August 10, 2023 12:25 — with GitHub Actions Inactive
@ashwin1111 ashwin1111 had a problem deploying to End to End Test - Staging August 10, 2023 12:25 — with GitHub Actions Failure
@ashwin1111 ashwin1111 had a problem deploying to End to End Test - Staging August 10, 2023 12:25 — with GitHub Actions Failure
@ashwin1111 ashwin1111 temporarily deployed to End to End Test - Staging August 10, 2023 12:25 — with GitHub Actions Inactive
@ashwin1111 ashwin1111 had a problem deploying to End to End Test - Staging August 10, 2023 12:25 — with GitHub Actions Failure
@ashwin1111 ashwin1111 had a problem deploying to End to End Test - Staging August 10, 2023 12:25 — with GitHub Actions Failure
@NileshPant1999 NileshPant1999 added the deploy Triggers deployment of active branch to Staging label Aug 23, 2023
@NileshPant1999 NileshPant1999 temporarily deployed to Staging August 23, 2023 06:54 — with GitHub Actions Inactive
@github-actions
Copy link

Unit Test Coverage % values
Statements 95.57% ( 3220 / 3369 )
Branches 87.1% ( 1094 / 1256 )
Functions 95.36% ( 885 / 928 )
Lines 95.89% ( 3156 / 3291 )

@NileshPant1999 NileshPant1999 removed the deploy Triggers deployment of active branch to Staging label Aug 28, 2023
@NileshPant1999 NileshPant1999 merged commit 0ea9bb9 into master Sep 6, 2023
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashwin1111 ashwin1111 ashwin1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NileshPant1999 @codecov-commenter @ashwin1111 @code-factor