feat: approver api specs for purpose #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siddharth-singh-1
commented
Jul 31, 2023
•
siddharth-singh-1
commented
KirtiGautam
reviewed
Jul 31, 2023
src/components/schemas/report.yaml
Outdated
| purpose: | ||
| type: string | ||
| description: | | ||
| Indicates purpose of the reports. It can only be updated for an existing report before it gets in `APPROVER_PENDING` state. |
There was a problem hiding this comment.
....before it gets in APPROVER_PENDING state. can be changed to ..before the report is moved to APPROVER_PENDING state.
There was a problem hiding this comment.
This is not fixed yet, Did you push changes yet?
KirtiGautam
reviewed
Jul 31, 2023
KirtiGautam
reviewed
Jul 31, 2023
src/components/schemas/report.yaml
Outdated
| purpose: | ||
| type: string | ||
| description: | | ||
| Indicates purpose of the reports. It can only be updated for an existing report before the report is moved to `APPROVER_PENDING` state. |
There was a problem hiding this comment.
This seems wrong. Approver can only edit purpose when the state of the report is APPROVER_PENDING according to ED.
KirtiGautam
approved these changes
Jul 31, 2023
… into FYLE-85ztnn88f
… into FYLE-85ztnn88f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.