-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for httpfs #27
Conversation
Signed-off-by: [email protected] <[email protected]>
afm/asset.py
Outdated
import os | ||
|
||
from afm.config import Config | ||
from afm.pep import registry, consolidate_actions | ||
from afm.s3 import s3filesystem_from_config | ||
|
||
from pyarrow.fs import LocalFileSystem | ||
from pyarrow.fs import LocalFileSystem, PyFileSystem, FSSpecHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move out of asset.py. We can create a filesystem package if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
httpfs seems like a 1 person project with zero adoption. Not saying that we can't use it but we need a requirement here and I'm not sure that we have one.
Also, technically, can you explain how this works? I don't see implementation of any of the FSSpecHandler
methods in HttpFs or fs.base.FS
Looking around it seems like pyarrow is compatible with
from fsspec.implementations.http import HTTPFileSystem |
I tried working with the fsspec HTTPFileSystem implementation.
It appears that fsspec HTTPFileSystem is not a friend of the parquet format. I could only get it to work when I applied the following patch to |
Pipfile
Outdated
requests = "*" | ||
fsspec = "*" | ||
aiohttp = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set these to fixed versions?
afm/filesystems/httpfs.py
Outdated
from fsspec.implementations.http import HTTPFileSystem | ||
from pyarrow.fs import PyFileSystem, FSSpecHandler | ||
|
||
def httpfs_from_config(httpfs_config): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we don't use config. Is it a placeholder for authentication or something? If so please add a comment
Signed-off-by: [email protected] [email protected]
Hi Roee,
I accidentally found a way to support httpfs.
Please review and check whether we want this support in the-mesh-for-data-flight-module.
Thanks!