Issue after adding aws-sdk-arduino-esp8266 version 1.0 to Arduino IDE #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awsDate is char[9] and awsTime is char[7]. AWSClient4::createRequest attempts to assign '\0' to awsDate[9] and awsTime[7], resulting in a buffer overflow and possible exception with debug message like "there is no poison after the block. Expected poison address:" from umm_malloc.c. Write '\0' to awsDate[8] and awsTime[6] instead.
DynamoDB needs https
More resilient response reading.
Off-by-one array index resulting in buffer overflow
Update to enable DynamoDB
This library has been tested with ESP8266 and ESP32. Some filenames that had 8266 in the name have had the 8266 removed to reflect that. Compilation was done with g++ -Wall option which explains why many char * have been changed to const char *. Also -Wall showed us some local variable errors in AWSClient4.cpp and we added some class members to fix that. I added a content-length header to canonical headers only because I was trying to follow AWS instructions literally. What really matters is that the signedHeaders set in AmazonIOTClient corresponds to those used. A couple of places I conditionally compile against ESP32 and/or ESP8266. Mainly that is to select which header files to include, but there is a functional thing in EspHttpClient::send that does not work for ESP32 as written so I left it out. I had to change the receive logic of that function to receive the entire response and close the persistent connection in a simple manner. Likewise, I modified updateCurlTime to avoid using readString() from the underlying stream.
Now there are no conditional header files specified in the library. The only conditional code remaining is WiFiClientSecure::verify, which does not exist under ESP32.
WiFiSSLClient vs WiFiClientSecure. Allow a variable SERIALUSB to change the debug serial port for Arduino cards.
Adding more platforms, ESP32, SAM, SAMD
Add get_shadow()
b-madhukar
changed the title
Each field of keywords.txt is separated by a single true tab. When you use multiple tabs it causes the field to be interpreted as empty. On Arduino IDE 1.6.5 and newer an empty KEYWORD_TOKENTYPE causes the default editor.function.style coloration to be used (as with KEYWORD2, KEYWORD3, LITERAL2). On Arduino IDE 1.6.4 and older it causes the keyword to not be recognized for any special coloration. Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords
Use a single tab field separator in keywords.txt
fuzzyhandle
reviewed
Aug 22, 2018
Libraries are locked to the `name` value specified by the library.properties metadata file in the release at the time of the Library Manager submission. Any release with a different name is rejected by the Arduino Library Manager indexer. References: - https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#why-arent-releases-of-my-library-being-picked-up-by-library-manager - https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#how-can-i-change-my-librarys-name
Revert library name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libraries which are downloaded from arduino library manager do not contain getshadow method in AmazonIOTClient.h file,
Can you please create a new build version and upload it to Arduino libraries with two examples
Thanks for your help in advance!!!!