Fix Broken Link to Lifx Docs For a Tile Object #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@furey thanks for your contributions on the tile functionality. Would you mind having a look at this one? |
|
Hi @domenic-corso, Thanks for reaching out! I'm no longer in possession of a Tile, so am no longer the right person to review this PR. 😞 That said, I took a quick look at your PR and while you've correctly patched links to "Tile" references, there are other outdated links in the README that'll need fixing too (e.g. "StateDeviceChain - 702" should be "StateDeviceChain - 702", etc). If you also fixed those links, @futomi is probably more likely to merge the PR? Best of luck! 🤓👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing link to a tile object on the LIFX Docs is broken. Looks like they've updated their documentation.