-
Notifications
You must be signed in to change notification settings - Fork 37
Add file list to package.json #739
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the contribution. I think this is very close to what we want to do. I think we do have a few deeply nested test folders currently that might need to be ignored, possibly with the !
operator.
Would you be up for trying to negate those here? Otherwise we would be happy to pick it up ourselves.
E.g., https://github.com/fusionjs/fusion-cli/tree/master/build/babel-plugins/babel-plugin-chunkid/test
@KevinGrandon added a generic negate rule |
Co-Authored-By: madhusudhand <[email protected]>
Co-Authored-By: madhusudhand <[email protected]>
Removed the optional entries README.md and LICENSE as per the review comments. |
I think
I'm wary of accidentally having necessary files being published, so perhaps it's better to instead explicitly say which files should not be published. |
fusion-cli npm modules includes all the files from source which makes it heavy.
Hence included only required files.