Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: update some settings files #947

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

skoudoro
Copy link
Contributor

@skoudoro skoudoro commented Dec 9, 2024

  • Remove vtk from pyproject.toml
  • python 3.10 as a minimum

@skoudoro skoudoro force-pushed the clean-setup-files branch 2 times, most recently from 7bfd311 to 9f2731f Compare December 9, 2024 21:03
@skoudoro skoudoro changed the title [WIP] RF: update some settings files RF: update some settings files Dec 9, 2024
@skoudoro
Copy link
Contributor Author

skoudoro commented Dec 9, 2024

This PR is ready to go.

A lot of follow-up PR to cleanup is needed. But this one is good as it is.

Can someone have a look @m-agour or @maharshi-gor or @Garyfallidis ?

Copy link
Contributor

@maharshi-gor maharshi-gor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @skoudoro just tiny suggestions, otherwise LGTM!

pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
Co-authored-by: Maharshi Gor <[email protected]>
@maharshi-gor maharshi-gor merged commit d57df65 into fury-gl:v2 Dec 11, 2024
2 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants