Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] fix warnings #939

Merged
merged 4 commits into from
Oct 12, 2024
Merged

[DOC] fix warnings #939

merged 4 commits into from
Oct 12, 2024

Conversation

robinroy03
Copy link
Member

@robinroy03 robinroy03 commented Oct 12, 2024

fix for #936

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @robinroy03! merging

@skoudoro
Copy link
Contributor

ah ok, it is a draft, waiting for the final version

@robinroy03
Copy link
Member Author

@skoudoro im having more py files coming

@robinroy03 robinroy03 marked this pull request as ready for review October 12, 2024 15:05
@robinroy03
Copy link
Member Author

@skoudoro check now.

Some tutorial .py files got numpy migration errors. I've not upgraded them here. The code here is just keyword error flags.
I'll open a new issue about the numpy migration errors.

@skoudoro
Copy link
Contributor

Thank you for this @robinroy03, it looks good, merging

@robinroy03 robinroy03 changed the title [WIP] Doc warnings [DOC] fix warnings Oct 12, 2024
@skoudoro skoudoro merged commit a09d2ce into fury-gl:master Oct 12, 2024
17 of 29 checks passed
@skoudoro skoudoro mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants