Solved the fetch_gltf argument errors. #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worked on a UserWarning by making sure all inputs to fetch_gltf were keyword arguments and changing those that were not
skoudoro
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Hi @kkoco2266,
Thank you very much for doing this!
I will look into it later today and come back to you
skoudoro
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Looks good to me, merging, thanks @robinroy03 for the review and thanks @kkoco2266 for this contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on a UserWarning by making sure all inputs to fetch_gltf were keyword arguments and changing those that were not.
fixes #937