Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unified dragging API to UI elements #635

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Nibba2018
Copy link
Member

Replaces boiler plate code in various UI elements to make them draggable.
Solves #401 .

Any new UI component can use self.set_draggable_components method from its UI super class to implement dragging without any additional code.

@Nibba2018 Nibba2018 marked this pull request as draft July 19, 2022 15:53
@Nibba2018 Nibba2018 marked this pull request as ready for review July 19, 2022 16:38
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #635 (f385250) into master (8e1cc27) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   50.19%   50.20%   +0.01%     
==========================================
  Files         120      120              
  Lines       28019    27965      -54     
  Branches     2987     2981       -6     
==========================================
- Hits        14063    14039      -24     
+ Misses      13489    13461      -28     
+ Partials      467      465       -2     
Impacted Files Coverage Δ
fury/ui/containers.py 0.00% <0.00%> (ø)
fury/ui/core.py 0.00% <0.00%> (ø)
fury/ui/elements.py 0.00% <0.00%> (ø)
fury/ui/tests/test_helpers.py 0.00% <ø> (ø)
fury/fury/ui/core.py 92.97% <0.00%> (-0.42%) ⬇️
fury/fury/ui/containers.py 83.05% <0.00%> (-0.32%) ⬇️
fury/fury/ui/elements.py 89.65% <0.00%> (-0.02%) ⬇️
fury/fury/ui/tests/test_helpers.py 100.00% <0.00%> (ø)
fury/fury/stream/tools.py 91.15% <0.00%> (+0.21%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants