Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 상품 및 꿀조합 검색 결과 API 페이징 방식 변경 #11

Merged
merged 11 commits into from
Jan 23, 2024
Merged

refactor: 상품 및 꿀조합 검색 결과 API 페이징 방식 변경 #11

merged 11 commits into from
Jan 23, 2024

Conversation

Go-Jaecheol
Copy link
Contributor

@Go-Jaecheol Go-Jaecheol commented Jan 15, 2024 •
edited
Loading

Issue

✨ 구현한 기능

상품 검색 결과 API, 꿀조합 검색 결과 API
AS-IS : Offset 기반 페이지네이션
TO-BE : Cursor 기반 페이지네이션

++

꿀조합 검색 결과: id 오름차순 정렬 -> 내림차순 정렬로 변경

📢 논의하고 싶은 내용

X

🎸 기타

X

⏰ 일정

  • 추정 시간 : 1h
  • 걸린 시간 : 2h

@Go-Jaecheol Go-Jaecheol self-assigned this Jan 15, 2024
wugawuga
wugawuga requested changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

충돌나는 코드만 수정부탁드려용

src/main/java/com/funeat/product/application/ProductService.java Outdated

final PageDto pageDto = PageDto.toDto(products);
final boolean hasNext = products.size() > DEFAULT_PAGE_SIZE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코틀린 문법인가여?

Copy link
Contributor Author

@Go-Jaecheol Go-Jaecheol Jan 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자바 문법인데 혹시 17로 버전 올려서 그런가여?!

근데 그것보다 이거 다시 보니까 로직상 잘못된 거 같은데 뭔가 이상하지 않나요..?
다시 한 번 봐야겠네요,,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직은 잘못된지 잘 모르겠어용
변수 = 조건식
이렇게 들어가는 건 처음 보는거 같아서용

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직 잘못됐어서 수정했어용

src/test/java/com/funeat/acceptance/product/ProductAcceptanceTest.java
// when
final var response = 상품_검색_결과_조회_요청("망고", FIRST_PAGE);
final var response = 상품_검색_결과_조회_요청("망고", 0L);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 아이디를 받는거라서 FIRST_PAGE 제거한건가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIRST_PAGE는 이름이 안맞는 거 같아서 바꿨는데, 얘도 상수로 빼버릴까요??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그대로 가도 될 거 같아요

@Go-Jaecheol Go-Jaecheol mentioned this pull request Jan 20, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2024 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f94d320.

♻️ This comment has been updated with latest results.

@Go-Jaecheol
Copy link
Contributor Author

hasNext 구하는 과정이 잘못됐었네요,, 한 번 더 확인 안했으면 놓칠뻔

기존에 다른 메서드에서 사용중인 getResultSize(), hasNextPage() 메서드 활용해서 수정했습니다!
수정하는 김에 검증 테스트도 더 추가했어요
ProductService에서는 파라미터 타입만 바꿔서 쓰면 돼서 해당 메서드들 제네릭 사용했는데,
RecipeService에 있는 기존 hasNextPage()는 Page를 파라미터로 받고 있어서 .getContent() 때문에 하나 새로 만들었어요.

이거 전에 머지된 상품 자동 완성 부분 로직도 수정해야 되는데, 이거 머지되면 수정해서 새로 PR 올릴게여

@Go-Jaecheol Go-Jaecheol merged commit f1f256e into develop Jan 23, 2024
3 checks passed
@Go-Jaecheol Go-Jaecheol deleted the feat/issue-7 branch January 23, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wugawuga wugawuga wugawuga requested changes

@70825 70825 Awaiting requested review from 70825

@hanueleee hanueleee Awaiting requested review from hanueleee

Assignees

@Go-Jaecheol Go-Jaecheol

Labels
🔧 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

상품 및 꿀조합 검색 결과 API 페이징 방식 변경
2 participants
@Go-Jaecheol @wugawuga