-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 마이페이지 구현 #95
feat: 마이페이지 구현 #95
Conversation
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-hinernsghu.chromatic.com/ |
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-dpwvvhaaiw.chromatic.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고했어요 해온 ~
이 페이지가 찐막인가요?
코멘트 확인해주세요
<h1 className={title}>{name}</h1> | ||
{link && ( | ||
<Link to={link} state={state}> | ||
<SvgIcon variant="arrowRight" width={20} height={20} /> | ||
<SvgIcon variant="arrowRight" width={20} height={20} style={{ transform: 'translateY(2px)' }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 👍
<StarRating rating={rating} createdAt={createdAt} /> | ||
<div style={{ height: '8px' }} /> | ||
|
||
{image && <img className={reviewImage} src={image} alt="작성한 리뷰" />} | ||
<div style={{ height: '8px' }} /> | ||
|
||
<Text size="caption2" color="sub"> | ||
{content} | ||
</Text> | ||
<div style={{ height: '8px' }} /> | ||
|
||
<TagList tags={tags} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 부분은 상품 리뷰랑 같아서 한번에 묶는거 어떤가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReviewItemInfo라는 컴포넌트로 따로 빼고 교체하였습니다!
@@ -59,6 +59,11 @@ export const CATEGORY_TYPE = { | |||
STORE: 'store', | |||
} as const; | |||
|
|||
export const POST_TYPE = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상수화 좋습니다 👍
plugins: [new Dotenv(), new VanillaExtractPlugin(), new MiniCssExtractPlugin()], | ||
plugins: [ | ||
new Dotenv(), | ||
new VanillaExtractPlugin({ identifiers: ({ hash }) => `prefix_${hash}` }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버그 픽스 좋습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 고생했어요 해온!!!!
import { vars } from '@/styles/theme.css'; | ||
import { style } from '@vanilla-extract/css'; | ||
|
||
export const container = style({}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얘는 삭제해도 될듯?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아니 이게 뭐야 삭제 완.
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-vdmlpgimik.chromatic.com/ |
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-sdvttrinuw.chromatic.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인완 ~ 고생했어요 해온! 그 outline 디자인엔 없다고 해서 없앴는데 그럼 그냥 outline 다 통일하는거 어떤가요
넵! 그럼 전체 outline 다 노란색으로 통일할게요~ 작업은 다른 이슈에서 하겠슴니당~~! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마이페이지도 고고~
Issue
✨ 구현한 기능
저장한 꿀조합 같은 경우 새로 api를 파야해서 작업하지 않았습니다.
여기서 하면 코드 너무 많아질 거 같고 회의가 필요한 거 같아서...!
member review와 member recipe의 api가 수정되었습니다.
노션에 수정해두었습니다!
근데 member review는 왜 노션에 안 보이나요...?
원래 따로 없었나요? 걍 제가 추가해놓음....
📢 논의하고 싶은 내용
webpack에 있는 VanillaExtractPlugin에 hash 값을 추가해주니까 해결 됨
아래 사진과 같은 오류가 발생하는데 왜 발생하는지 아시는 분 있나요?(해결 완)정확히 MemberRecipeList에서 DefaultRecipeItem 컴포넌트를 추가하면 뜹니다.
오류 복사 내용
이거 지금 하드코딩으로 넣어놨는데, 이 값 context로 저장해서 가져오는게 맞을까요??
🎸 기타
MemberPostPage의 경우 css가 없는데 폴더에 있습니다.
이거 css 작업하다가 필요 없어져서 css만 삭제한 상태인데,
나중에 스타일 필요해서 그냥 폴더 상태로 두겠습니다!
⏰ 일정