�v2.1.2 (#150)

v2.1.2
fun-eat · Jun 7, 2024 · b99e324 · b99e324
2 parents c7d40ba + f2beade
commit b99e324
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 9 deletions.
diff --git a/src/components/Rank/ReviewRankingItem/reviewRankingItem.css.ts b/src/components/Rank/ReviewRankingItem/reviewRankingItem.css.ts
@@ -3,7 +3,7 @@ import { style } from '@vanilla-extract/css';
 
 export const reviewImage = style({
   width: '100%',
-  height: 'auto',
+  height: 90,
   borderRadius: '6px',
   objectFit: 'cover',
   aspectRatio: '164 / 90',

diff --git a/src/components/Rank/ReviewRankingList/reviewRankingList.css.ts b/src/components/Rank/ReviewRankingList/reviewRankingList.css.ts
@@ -3,13 +3,14 @@ import { style } from '@vanilla-extract/css';
 
 export const container = style({
   display: 'flex',
+  justifyContent: 'space-between',
   gap: 10,
   padding: '0 20px',
   overflowX: 'auto',
 });
 
 export const reviewItemWrapper = style({
-  minWidth: 164,
+  maxWidth: 164,
 });
 
 export const bottomSheetWrapper = style({

diff --git a/src/components/Review/BestReviewItem/BestReviewItem.tsx b/src/components/Review/BestReviewItem/BestReviewItem.tsx
@@ -30,7 +30,7 @@ const BestReviewItem = ({ productId }: BestReviewItemProps) => {
         <BestReviewItemContainer>
           <ReviewRateFavoriteWrapper>
             <ReviewerInfoWrapper>
-              <MemberImage src={profileImage} width={32} height={32} alt={`${userName}의 프로필`} />
+              <MemberImage src={profileImage} width={32} height={32} />
               <div>
                 <Text size="sm" weight="bold">
                   {userName} 님

diff --git a/src/index.tsx b/src/index.tsx
@@ -42,7 +42,7 @@ root.render(
     <QueryClientProvider client={queryClient}>
       <FunEatProvider>
         <SvgSprite />
-        <RouterProvider router={router} fallbackElement={<p>...loading</p>} />
+        <RouterProvider router={router} />
       </FunEatProvider>
       <ReactQueryDevtools initialIsOpen={false} />
     </QueryClientProvider>

diff --git a/src/mocks/data/reviewRankingList.json b/src/mocks/data/reviewRankingList.json
@@ -28,7 +28,7 @@
       "productId": 1,
       "productName": "구운감자슬림명란마요",
       "content": "할머니가 먹을 거 같은 맛입니다. 1960년 전쟁 때 맛 보고 싶었는데 그때는 너무 가난해서 먹을 수 없었는데요 이것보다 긴 리뷰도 잘려 보인답니다",
-      "image": "",
+      "image": "https://image.funeat.site/prod/c02bbc38-d9d5-4217-9c18-7b28995a9344-0001.webp",
       "categoryType": "food",
       "rating": 4.5,
       "tags": [

diff --git a/src/pages/LoginPage/LoginPage.tsx b/src/pages/LoginPage/LoginPage.tsx
@@ -1,4 +1,4 @@
-import { Link, Navigate } from 'react-router-dom';
+import { Navigate } from 'react-router-dom';
 
 import { buttonWrapper, container, imageWrapper, kakaoButton, main, wrapper } from './loginPage.css';
 
@@ -40,12 +40,12 @@ export const LoginPage = () => {
           </div>
 
           <div className={buttonWrapper}>
-            <Link to={loginLink} className={kakaoButton}>
+            <a href={loginLink} className={kakaoButton}>
               <SvgIcon variant="kakao" width={20} height={20} />
               <Text as="span" size="caption1" weight="semiBold">
                 카카오 로그인
               </Text>
-            </Link>
+            </a>
           </div>
         </section>
       </main>

diff --git a/src/pages/RecipeDetailPage/RecipeDetailPage.tsx b/src/pages/RecipeDetailPage/RecipeDetailPage.tsx
@@ -53,7 +53,7 @@ export const RecipeDetailPage = () => {
       <main className={main}>
         <section className={container}>
           <div className={authorWrapper}>
-            <MemberImage src={author.profileImage} alt={`${author.nickname}님의 프로필`} width={34} height={34} />
+            <MemberImage src={author.profileImage} width={34} height={34} />
             <div>
               <Text size="caption2" weight="semiBold">
                 {author.nickname}