Fix osu!lazer updates #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The updater still uses the npins json file for info. This does not solve anything. The updater script should be modified to only take into account the latest release if it has an appimage. And osu-lazer-bin should be removed from npins. |
|
osu!lazer has been removed from npins as requested. We now rely on the Github API directly to get new releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osu!lazer has been pushing more than a few tags without release artifacts recently. This tends to break builds because while the
info.jsonfile is updated properly, the version is still fetched from npins directly, causing a 404.This fixes the issue by sourcing the version from
info.jsondirectly to ensure that we get a tag with a release attached.