Merge pull request rustdesk#6194 from fufesou/fix/comments_infinite_loop

add comemnt
fufesou · Oct 27, 2023 · 8a2bd1c · 8a2bd1c
2 parents 8cc9e30 + de35630
commit 8a2bd1c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/flutter/lib/common/widgets/peers_view.dart b/flutter/lib/common/widgets/peers_view.dart
@@ -190,7 +190,13 @@ class _PeersViewState extends State<_PeersView> with WindowListener {
                 child: widget.peerCardBuilder(peer),
               );
               final windowWidth = MediaQuery.of(context).size.width;
-              final currentTab = gFFI.peerTabModel.currentTab;
+              // `Provider.of<PeerTabModel>(context)` will causes infinete loop.
+              // Because `gFFI.peerTabModel.setCurrentTabCachedPeers(peers)` will trigger `notifyListeners()`.
+              //
+              // No need to listen the currentTab change event.
+              // Because the currentTab change event will trigger the peers change event,
+              // and the peers change event will trigger _buildPeersView().
+              final currentTab = Provider.of<PeerTabModel>(context, listen: false).currentTab;
               final hideAbTagsPanel = bind.mainGetLocalOption(key: "hideAbTagsPanel").isNotEmpty;
               return isDesktop
                   ? Obx(