Chromium support #38
Chromium support #38
Conversation
Stvad
force-pushed
the
chromium
branch
2 times, most recently
from
0fa63b1 to
d28753a
Compare
v3 has a bunch of breaking changes without much benefit afaik, so would be nice if we can publish some version before Jan 17 to avoid having to deal with that for a while |
|
Also hitting https://stackoverflow.com/questions/36478250/cannot-access-wikidata-api because in the context of content-script fetch becomes a CORS request and wikidata api blocks those for some reason. Seems they broke it in Chrome specifically and kind of recently =\ https://www.chromium.org/Home/chromium-security/extension-content-script-fetches |
|
ah, so apparently can work around that by adding |
Stvad
force-pushed
the
chromium
branch
4 times, most recently
from
e7fa033 to
5711c13
Compare
src/background/index.js
Outdated
| tabStates[tid].sidebarOpen = false; | ||
| } | ||
| } else { | ||
| openEnitiyInNewTab(tabStates[tid].entity); | ||
| //todo need better handling here if we actually want "open in new tab" behavior in some cases |
There was a problem hiding this comment.
@fuddl do we want that behavior?
I see a few commits on having "an alternative to sidebar" but I'm note entirely sure what was the overall vision there 🤔
Stvad
force-pushed
the
chromium
branch
2 times, most recently
from
03f730e to
5b4cb0d
Compare
…ify updateStatus & updateStatusInternal
…operly supply the tabId now
#13 Currently at the level of PoC (that works)
Relies on #34, so would become more legible when that is merged
Todo
Blocking:
Alt-3is a default valuematch_eventis handled)todos and incompatibilitiesFollow-up:
Issues