Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml doc comments and tests for discrete padRnd. #307

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

OwenMadden
Copy link
Contributor

Thank you for contributing to FSharp.Stats. Please take the time to tell us a bit more about your PR.

Please reference the issue(s) this PR is related to

Part of #281
Filled in xml doc comments for Discrete.padRnd function. Added code example and test for example.

A few sentences about your contribution
Filled in xml doc comments for Discrete.padRnd function. Added code example and test for example. Test that the padded data contains data taken from the original data set.

[Required] please make sure you checked that

  • [Yes ] The project builds without problems on your machine

[Optional]

  • [Yes] Added unit tests regarding the added features

@codecov-commenter
Copy link

Codecov Report

Merging #307 (28106c7) into developer (e4fd26a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           developer     #307      +/-   ##
=============================================
+ Coverage      46.73%   46.74%   +0.01%     
=============================================
  Files            148      148              
  Lines          16225    16230       +5     
  Branches        2196     2196              
=============================================
+ Hits            7582     7587       +5     
  Misses          7987     7987              
  Partials         656      656              
Files Coverage Δ
src/FSharp.Stats/Signal/Padding.fs 0.00% <ø> (ø)
tests/FSharp.Stats.Tests/Signal.fs 98.74% <100.00%> (+0.04%) ⬆️

@bvenn bvenn merged commit 2c0d3de into fslaborg:developer Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants