Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge strategies for maps #264

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Add merge strategies for maps #264

merged 5 commits into from
Apr 27, 2023

Conversation

bvenn
Copy link
Member

@bvenn bvenn commented Apr 26, 2023

Thank you for contributing to FSharp.Stats. Please take the time to tell us a bit more about your PR.

Please reference the issue(s) this PR is related to

#263

Please list the changes introduced in this PR

  • Addition of Map.merge, Map.mergeBy, Map.mergeSubtract, and Map.mergeAdd
  • Addition of Frequency.merge, Frequency.subtract, and Frequency.add
  • Addition of Empirical.merge, Empirical.mergeBy, and Empirical.add
  • Addition of Distribution.Empirical documentation

Description

Maps are the foundation of modules Frequency and Distribution.Empirical. Frequency maps can be merged of data histograms should be combined. Generic mergeBy functions enable to decide what happens when keys are present in both input maps.

[Required] please make sure you checked that

  • The project builds without problems on your machine

[Optional]

  • Added unit tests regarding the added features

@codecov-commenter
Copy link

Codecov Report

Merging #264 (814ae18) into developer (3d6a220) will increase coverage by 0.08%.
The diff coverage is 61.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##           developer     #264      +/-   ##
=============================================
+ Coverage      46.41%   46.49%   +0.08%     
=============================================
  Files            152      153       +1     
  Lines          15255    15304      +49     
  Branches        1980     1983       +3     
=============================================
+ Hits            7080     7115      +35     
- Misses          7628     7641      +13     
- Partials         547      548       +1     
Impacted Files Coverage Δ
src/FSharp.Stats/Distributions/Frequency.fs 0.00% <0.00%> (ø)
src/FSharp.Stats/Distributions/Empirical.fs 24.41% <33.33%> (+0.96%) ⬆️
src/FSharp.Stats/Map.fs 66.66% <66.66%> (ø)
tests/FSharp.Stats.Tests/DistributionsEmpirical.fs 100.00% <100.00%> (ø)

@bvenn bvenn merged commit 4f71652 into developer Apr 27, 2023
@bvenn bvenn deleted the #263-add-map-merge branch April 27, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants