feat: upgrade to net9 #56
Conversation
HBTeun
commented
Nov 13, 2024
HBTeun
commented
- Upgraded the build container to NET 9
- Kept runtime support for NET 8
- [BREAKING] Dropped support for NET 7
HBTeun
force-pushed
the
feature/upgrade-to-net9
branch
from
039b0a1 to
2519fd6
Compare
| @@ -27,7 +27,7 @@ RUN apt-get update \ | |||
| && apt-get clean && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| # install docker-compose | |||
| RUN curl -L "https://github.com/docker/compose/releases/download/v2.16.0/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose \ | |||
| RUN curl -L "https://github.com/docker/compose/releases/download/v2.29.7/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose \ | |||
| && chmod +x /usr/local/bin/docker-compose | |||
|
|
|||
| # install Chromium for (unit)-testing during build-phase | |||
There was a problem hiding this comment.
As far as I see line 35 is already done on line 21. This comment has nothing to do with what is shown above.
I meant the following:
|
Looking good 👍! Hyped to start using .net 9 🥳 |
CHANGELOG.md
Outdated
|
|
||
| - Updated to NET 9 SDK Container | ||
| - Update to Node 20 | ||
| - Update Docker to v2.29.7 |
| @@ -49,12 +49,6 @@ RUN mkdir -p ~/scripts | |||
| COPY scripts /scripts | |||
| RUN echo "source /scripts/dotnetcore.sh" >> ~/.bashrc | |||
|
|
|||
| # install reportgenerator for code coverage | |||
| RUN dotnet tool install -g dotnet-reportgenerator-globaltool | |||
There was a problem hiding this comment.
Why did you move this to the dotnet-build.sh file?
This way it will execute the tool install every time you run the container.
Tools should really be included in the container so we have a static and replayable environment between builds
There was a problem hiding this comment.
I removed them because they sometimes resulted in errors because they could not not be updated because it was a fixed container layer.
Normally for dotnet tools this is done using a local tool manifest file in the repo. NPM tools are also not in the container.
Plus the "tool install every time" can be partly solved with using the Bitbucket pipeline cache better.
HBTeun
force-pushed
the
feature/upgrade-to-net9
branch
from
2519fd6 to
99541c6
Compare
HBTeun
force-pushed
the
feature/upgrade-to-net9
branch
from
99541c6 to
414c30b
Compare
