Disable nullable type expression for sorting #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patheems
approved these changes
Feb 17, 2022
|
The first PR I created was already targeting the real repo, so closed that again. But yes we want to merge it with the original. |
Mastermindzh
approved these changes
Feb 17, 2022
val-andrushko
approved these changes
Feb 17, 2022
added 3 commits
February 17, 2022 16:34
…ithub.com/Inforitnl/Sieve into feature/disableSortNullableTypeExpression
patheems
approved these changes
Feb 17, 2022
pascal89
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB has issues with the expression created when sorting on nullable types.
So created an option to disable it.
Please also comment on things like the name of the variables/properties