fix: Add Type <T>

[philipbrembeck]

Summary by Sourcery

Improve type safety in the readJsonFile function by adding a generic type parameter and update JSON files to reflect changes in vegan and non-vegan ingredient lists.

Bug Fixes:

• Add generic type parameter to the readJsonFile function to ensure type safety when parsing JSON data.

Chores:

• Update the isnotvegan.json file by adding 'E631' and 'E1105' to the list.
• Update the isvegan.json file by removing 'E631' and 'E999' from the list.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a generic type parameter to the readJsonFile function for improved type safety, and updates the isnotvegan.json and isvegan.json files with some ingredient changes.

Class diagram for updated readJsonFile function

classDiagram
    class JsonFileReader {
        +readJsonFile<T>(filePath: string): Promise<T>
    }

Loading

File-Level Changes

Change	Details	Files
Add generic type parameter to readJsonFile function	Introduce generic type parameter to the function signature Update the return type to Promise Cast the parsed JSON data to type T	src/ingredients/jsonFileReader.ts
Update non-vegan ingredients list	Add 'E631' to the list of non-vegan ingredients Replace 'E966' with 'E1105' in the list	isnotvegan.json
Update vegan ingredients list	Remove 'E631' from the list of vegan ingredients Remove 'E999' from the list of vegan ingredients	isvegan.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @philipbrembeck - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}