Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Infineon BLDC IFX007T Shield #329

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

r-nikhita
Copy link

No description provided.

@mMerlin
Copy link
Contributor

mMerlin commented May 12, 2021

403 modified files needs a lot more description than "Adding Infineon BLDC IFX007T Shield" It would appear that some sort of bulk process was run. What was it? What was it supposed to do? Even general cleanup needs a description about WHAT the purpose is. Sliding it in as part of an "add* is not good.

@pandayswarnam
Copy link

Hi @mMerlin,
This part is a motor driver shield from Infineon portfolio. This is the first time I wanted to have Infineon parts in fritzing tool. We followed the contribution guideline and did the changes as per the readme, then opened a pull request for the same. If this seems not to be the correct way, kindly suggest.

thanks
Swarnam

@mMerlin
Copy link
Contributor

mMerlin commented May 13, 2021

Your description of the submission process is correct, however that should have resulting in only 4 or 5 new files. not 400+ modified. Something you did in the fork of the repo modified a lot of existing files. It should have only added new files for the new part. One fzp part description file plus up to 4 svg file (one for each view). There should not have been any modifications to pre-existing files.

Exception to existing file modifications: If the part is to be added to an existing bin, the file for the bin gets modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants