-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1635 unexpected missing label error when ignoring header case #1638
Closed
amelie-rondot
wants to merge
15
commits into
frictionlessdata:main
from
amelie-rondot:Fix-1635-unexpected-missing-label-error-when-ignoring-header-case
Closed
Fix 1635 unexpected missing label error when ignoring header case #1638
amelie-rondot
wants to merge
15
commits into
frictionlessdata:main
from
amelie-rondot:Fix-1635-unexpected-missing-label-error-when-ignoring-header-case
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…part in '__open_row_stream()' 'TableResource' method
…schema_sync' 'Detector' option
This PR is replaced by PR#1641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
header_case = False
#1635This PR fixes unexpected
missing-label
error in validation report which occurs when validating tabular data in this specific case: The data contains a named column corresponding to a required fieldin the schema used for validation, written without respecting case-sensitivity.For example:
This PR adds some test cases:
schema_sync=True
anddialect=Dialect(header_case=False)
options, returns a valid report.schema_sync=True
anddialect=Dialect(header_case=False)
options, returns an invalid report withmissing-label
error related to field "AA".Finally, I suggest some refactoring in this PR:
schema_sync
option indetect_schema()
Detector
method