Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
# Description As described in #1660, the `stringified` attribute is not copied during the `to_copy()` as it is not included in the `metadata_profile_patch`. This commit fixes it by adding it to the `metadata_profile_patch` and updates the documentation to clarify the interaction of `stringified` and schemas. This also inclues a unit test to verify the bug fix. - fixes #1660 - fixes #1659 # Tests Ensure the new unit test detects the issue before the fix: ``` > pytest frictionless/formats/excel/__spec__/test_control.py::test_excel_control_to_copy [...] > assert control_copy == control_with_changed_attributes E AssertionError: assert {'type': 'exc...tError': True} == {'type': 'exc...tError': True} E E Omitting 8 identical items, use -vv to show E Differing attributes: E ['stringified'] E E Drill down into differing attribute stringified: E stringified: False != True frictionless/formats/excel/__spec__/test_control.py:25: AssertionError ``` Ensure the unit test runs and passes after the fix: ``` > pytest frictionless/formats/excel/__spec__/test_control.py::test_excel_control_to_copy -v [...] frictionless/formats/excel/__spec__/test_control.py::test_excel_control_to_copy PASSED [100%] ```
- Loading branch information